build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35994 )
Change subject: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK.
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35994/9/src/cpu/x86/mtrr/xip_cache....
File src/cpu/x86/mtrr/xip_cache.c:
https://review.coreboot.org/c/coreboot/+/35994/9/src/cpu/x86/mtrr/xip_cache....
PS9, Line 58: if (end < ALIGN_UP(base, mtrr_mask_size) &&
trailing statements should be on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35994
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0b50d2f56e7cc0e055cdc8b9aa28794327eca28
Gerrit-Change-Number: 35994
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 13 Oct 2019 13:12:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment