Attention is currently required from: Nico Huber, Stefan Reinauer, Paul Menzel, Rocky Phagura, Christian Walter, Angel Pons, Arthur Heymans, Kyösti Mälkki, Peter Tsung Ho Wu, Deomid "rojer" Ryabkov, Ron Minnich.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56386 )
Change subject: Add console deinit API, use in SMM handler
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56386/comment/9ff1d452_19ab810c
PS11, Line 14: on an OCP Delta Lake server: uart8250_init disables interrupts because it
yes in coreboot stage it's fine, but this change is for entering and exiting smm while printing smm […]
So uart8250_init() is called via console_init() in smi_handler() / smm_handler_start() (depending on which SMM modules are used or not).
Various things in the handler really should only be called the first time, and console_init belongs in that group IMHO: among other reasons because we don't want to see "\n\ncoreboot-%s%s %s " ENV_STRING " starting (log level: %i)...\n" emitted on every SMM. (see end of console_init() )
Our serial driver is simple enough that it should cope with most UART reconfiguration the OS might do while not actively using the serial port (in which case SMM should be configured not to interfere with OS talk on that line anyway)
+Stefan, do you remember what's going on here? What am I missing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5e51f385f83cb998c244ca1d1ffc10339d3a714
Gerrit-Change-Number: 56386
Gerrit-PatchSet: 11
Gerrit-Owner: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 07:10:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment