Change in coreboot[master]: mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45557 )
Change subject: mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax ......................................................................
mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax
Change-Id: I41778aff742749934da1ed122f3aa13821638604 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/acpi/platform.asl 1 file changed, 21 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/45557/1
diff --git a/src/mainboard/getac/p470/acpi/platform.asl b/src/mainboard/getac/p470/acpi/platform.asl index 98cecbc..3c092cf 100644 --- a/src/mainboard/getac/p470/acpi/platform.asl +++ b/src/mainboard/getac/p470/acpi/platform.asl @@ -9,23 +9,23 @@ TRAP(0xed) Sleep(1000)
- Store(0, _SB.ACFG) + _SB.ACFG = 0
// Are we going to S4? - If (Lequal(Arg0, 4)) { + If (Arg0 == 4) { TRAP(0xe7) TRAP(0xea) }
// Are we going to S5? - If (Lequal(Arg0, 5)) { + If (Arg0 == 5) { TRAP(0xde) }
// The 2.6.12.5 ACPI engine seems to optimize the - // If(LEqual(Arg0, 5)) path away. This keeps it from doing so: + // If((Arg0 == 5) path away. This keeps it from doing so: TRAP(Arg0) - Store(Arg0, DBG0) + Arg0, DBG0 = Arg0 // End of ugly OS bug workaround }
@@ -34,12 +34,12 @@ Method(_WAK,1) { // Enable GPS - Store (1, GP11) // GPSE + GP11 = 1 // GPSE
// Wake from S3 or S4? - If (LOr(LEqual(Arg0, 3), LEqual(Arg0, 4))) { - If (And(CFGD, 0x01000000)) { - If (LAnd(And(CFGD, 0xf0), LEqual(OSYS, 2001))) { + If ((Arg0 == 0x03) || (Arg0 == 0x04)) { + If (CFGD & 0x01000000) { + If ((CFGD & 0xF0) && (OSYS == 2001)) { TRAP(0x3d) } } @@ -48,26 +48,26 @@ // Notify PCI Express slots in case a card // was inserted while a sleep state was active.
- If (LEqual(RP1D, 0)) { + If (RP1D == 0) { Notify(_SB.PCI0.RP01, 0) }
- If (LEqual(RP3D, 0)) { + If (RP3D == 0) { Notify(_SB.PCI0.RP03, 0) }
- If (LEqual(RP4D, 0)) { + If (RP4D == 0) { Notify(_SB.PCI0.RP04, 0) }
// Are we coming from S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { TRAP(0xeb) TRAP(0x46) }
// Are we coming from S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { Notify(SLPB, 0x02) If (DTSE) { TRAP(0x47) @@ -75,16 +75,16 @@ }
// Windows XP SP2 P-State restore - If (LAnd(LEqual(OSYS, 2002), And(CFGD, 1))) { - If (LGreater(_SB.CP00._PPC, 0)) { - Subtract(_SB.CP00._PPC, 1, _SB.CP00._PPC) + If ((OSYS == 2002) && (CFGD & 0x01)) { + If (_SB.CP00._PPC > 0) { + _SB.CP00._PPC -= 1 PNOT() - Add(_SB.CP00._PPC, 1, _SB.CP00._PPC) + _SB.CP00._PPC += 1 PNOT() } Else { - Add(_SB.CP00._PPC, 1, _SB.CP00._PPC) + _SB.CP00._PPC += 1 PNOT() - Subtract(_SB.CP00._PPC, 1, _SB.CP00._PPC) + _SB.CP00._PPC -= 1 PNOT() } } @@ -118,7 +118,7 @@ * running: Windows XP SP1 needs to have C-State coordination * enabled in SMM. */ - If (LAnd(LEqual(OSYS, 2001), MPEN)) { + If ((OSYS == 0x07D1) && MPEN) { TRAP(0x3d) }
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45557 )
Change subject: mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45557/1/src/mainboard/getac/p470/ac... File src/mainboard/getac/p470/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/45557/1/src/mainboard/getac/p470/ac... PS1, Line 28: Arg0, DBG0 = Arg0 DBG0 = Arg0
https://review.coreboot.org/c/coreboot/+/45557/1/src/mainboard/getac/p470/ac... PS1, Line 121: 0x07D1 You didn't change the comparison above (line 78) either, so why here?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45557
to look at the new patch set (#2).
Change subject: mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax ......................................................................
mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax
Change-Id: I41778aff742749934da1ed122f3aa13821638604 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/acpi/platform.asl 1 file changed, 21 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/45557/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45557 )
Change subject: mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45557/1/src/mainboard/getac/p470/ac... File src/mainboard/getac/p470/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/45557/1/src/mainboard/getac/p470/ac... PS1, Line 28: Arg0, DBG0 = Arg0
DBG0 = Arg0
:))) Thx
https://review.coreboot.org/c/coreboot/+/45557/1/src/mainboard/getac/p470/ac... PS1, Line 121: 0x07D1
You didn't change the comparison above (line 78) either, so why here?
Thx
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45557 )
Change subject: mb/getac/p470/acpi: Convert 'platform.asl' to ASL 2.0 syntax ......................................................................
Abandoned
see 45555
-
HAOUAS Elyes (Code Review) -
Tim Wawrzynczak (Code Review)