Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Paul Menzel.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57119 )
Change subject: driver/i2c/max98390: add dsm_param_name
......................................................................
Patch Set 18:
(2 comments)
File src/drivers/i2c/max98390/max98390.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127586):
https://review.coreboot.org/c/coreboot/+/57119/comment/5c35aeca_f14689b0
PS18, Line 30: char dsm_name[80]={};
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127586):
https://review.coreboot.org/c/coreboot/+/57119/comment/ceceb6f0_20514871
PS18, Line 70: snprintf(dsm_name, sizeof(dsm_name), "%s_%s_%s.bin", config->dsm_param_file_name,
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57119
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I006572d6a6ea55298374c688dfd9d877835da82d
Gerrit-Change-Number: 57119
Gerrit-PatchSet: 18
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 07 Sep 2021 09:33:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment