Attention is currently required from: Uwe Poeche, Andrey Petrov. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63546 )
Change subject: intel/common/block: provide config switches from APL specific ......................................................................
Patch Set 2: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63546/comment/5085a91e_99f6ea1c PS2, Line 7: provide config switches from APL specific This could be formulated more clear, e.g.: 'intel/common/block: Provide RAPL and min clock ratio switches in common' or the like
https://review.coreboot.org/c/coreboot/+/63546/comment/aa5b8a38_3eab939d PS2, Line 10: APL_SKIP_SET_POWER_LIMITS APL_SET_MIN_CLOCK_RATIO
https://review.coreboot.org/c/coreboot/+/63546/comment/d2e48349_6e04a537 PS2, Line 12: Therefore they moved here with other name to common/block. Maybe 'Move them to common code instead of having them just for one SOC'
https://review.coreboot.org/c/coreboot/+/63546/comment/7251d0dd_2871f1fa PS2, Line 14: mainboards mc_apl1/4/5: compare cpu clock via MSR 0x198 and RAPL : settings via MSR 0x610 before and after the change. Maybe: Make sure that the clock ratio (MSR 0x198) and the RAPL settings (MSR0x610) do not change with this patch applied on mc_apl{1,4,5} mainboard.
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/63546/comment/d585db15_c9275c2f PS2, Line 144: Some Apollo Lake mainboards do not need the Running Average Power : Limits (RAPL) algorithm for a constant power management. : Set this config option to skip the RAPL configuration. I would rephrase this text as it is not APL specific anymore