[M] Change in coreboot[main]: mb/google/fatcat: Add ISH support with FW_CONFIG toggle - coreboot-gerrit

7 Nov 2024


      Attention is currently required from: Bora Guvendik, Pranava Y N, Subrata Banik.
Li1 Feng has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84998?usp=email )
Change subject: mb/google/fatcat: Add ISH support with FW_CONFIG toggle
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/84998/comment/372d924a_ec87461b?usp... :
PS2, Line 469: static const struct pad_config ish_enable_pads[] = {
...
...
In the enable, D5&6 are for UART0 […]
Sure, I will update them.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84998?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a9734139a49be982a7dd43d5afd92e7fea6b29c
Gerrit-Change-Number: 84998
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Li1 Feng li1.feng@intel.com
Gerrit-Reviewer: Pranava Y N pranavayn@google.com
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Pranava Y N pranavayn@google.com
Gerrit-Comment-Date: Thu, 07 Nov 2024 21:25:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Li1 Feng li1.feng@intel.com