Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/58425 )
Change subject: curl: Mark curl_easy_setopt() results non-interesting ......................................................................
curl: Mark curl_easy_setopt() results non-interesting
We don't care about them (and I don't know if we need to) so help tooling (e.g. Coverity Scan CID #359813) by making this decision explicit.
Signed-off-by: Patrick Georgi pgeorgi@google.com Change-Id: I8b192778ec73bf001c2e88a97065b5bbc25dd619 --- M curl.c 1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/25/58425/1
diff --git a/curl.c b/curl.c index 5fad845..302547e 100644 --- a/curl.c +++ b/curl.c @@ -84,33 +84,33 @@ strncat(url, id, URL_BUFFER_SIZE - 1);
/* Set URL to GET here */ - curl_easy_setopt(curl, CURLOPT_URL, url); + (void)curl_easy_setopt(curl, CURLOPT_URL, url); #ifdef DEBUG /* Switch on protocol/debug output for testing */ - curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L); + (void)curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L); #endif
/* Some servers don't like requests without a user-agent field. */ - curl_easy_setopt(curl, CURLOPT_USERAGENT, "em100-agent/1.0"); + (void)curl_easy_setopt(curl, CURLOPT_USERAGENT, "em100-agent/1.0");
/* Write callback to write the data to disk */ - curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_data); + (void)curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_data);
/* Write data to this file handle */ - curl_easy_setopt(curl, CURLOPT_WRITEDATA, file); + (void)curl_easy_setopt(curl, CURLOPT_WRITEDATA, file);
#if LIBCURL_VERSION_NUM >= 0x073200 if (progress) { /* Simple progress indicator function */ - curl_easy_setopt(curl, CURLOPT_XFERINFOFUNCTION, xferinfo); + (void)curl_easy_setopt(curl, CURLOPT_XFERINFOFUNCTION, xferinfo);
/* Enable progress indicator */ - curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 0L); + (void)curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 0L); } #endif
/* Follow redirections (as used by Google Drive) */ - curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION , 1L); + (void)curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION , 1L);
/* Fetch the file */ res = curl_easy_perform(curl);