Attention is currently required from: Tim Wawrzynczak, Julius Werner.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro()
......................................................................
Patch Set 9:
(2 comments)
File src/include/bootmode.h:
https://review.coreboot.org/c/coreboot/+/58896/comment/18d3cba5_35b617ef
PS7, Line 17: bool mainboard_ec_running_ro(void);
ah right ec_is_trusted() has the latched behavior.
Ack
File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58896/comment/2e76fe82_e37f3a9d
PS5, Line 14: void fill_lb_gpios(struct lb_gpios *gpios)
Butterfly did not use a Chrome EC, so I'm pretty sure it didn't have that line.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58896
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cb95268424dc27f8c1e26b3d34eff1a7b8eab7f
Gerrit-Change-Number: 58896
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 04 Feb 2022 04:45:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment