Attention is currently required from: Fabian Groffen.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77046?usp=email )
Change subject: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/gigabyte/ga-h77m-d3h/gpio.c:
https://review.coreboot.org/c/coreboot/+/77046/comment/746b2dda_d9fab144 : PS3, Line 30: GPIO_MODE_NATIVE Should be GPIO_MODE_GPIO as DRAM_RESET_GATE_GPIO is 25.
https://review.coreboot.org/c/coreboot/+/77046/comment/c38dffde_4e842ea0 : PS3, Line 40: GPIO_DIR_OUTPUT please clean the structs. Native pins do not need an entry in pch_gpio_set_direction and neither in pch_gpio_set_level. Input pins do not need an entry in pch_gpio_set_level.
As the default is 0 you can omit every entry that evaluates to 0.