[S] Change in coreboot[master]: {driver, soc/intel/cmn/cse}: Refactor ISH FW Version implementation - coreboot-gerrit

17 Aug 2023


      Attention is currently required from: Dinesh Gehlot, Julius Werner, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77176?usp=email )
Change subject: {driver, soc/intel/cmn/cse}: Refactor ISH FW Version implementation
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/77176/comment/b467b4ee_f2588976 :
PS3, Line 1345: 	if (!is_cbmem_cse_info_valid(info) ||
...
nit: technically I guess this isn't really necessary here anymore because now that you always check  […]
Acknowledged
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/77176?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0242c26dd90d834815799f54740d8147ff9d45b7
Gerrit-Change-Number: 77176
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 17 Aug 2023 22:21:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment