Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36616 )
Change subject: Kconfig: Organize debugging options per file extensions ......................................................................
Kconfig: Organize debugging options per file extensions
Change-Id: Ia4553fb4cd95d2f1fa86eecbf382e6e6dec52b92 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/Kconfig R src/cpu/x86/Kconfig.debug_cpu 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36616/1
diff --git a/src/Kconfig b/src/Kconfig index 793927a..38796b4 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -738,7 +738,10 @@ menu "Debugging"
comment "CPU Debug Settings" -source "src/cpu/*/Kconfig.debug" +source "src/*/Kconfig.debug_cpu" +source "src/*/*/Kconfig.debug_cpu" +source "src/*/*/*/Kconfig.debug_cpu" +source "src/*/*/*/*/Kconfig.debug_cpu"
comment "General Debug Settings"
diff --git a/src/cpu/x86/Kconfig.debug b/src/cpu/x86/Kconfig.debug_cpu similarity index 100% rename from src/cpu/x86/Kconfig.debug rename to src/cpu/x86/Kconfig.debug_cpu
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36616 )
Change subject: Kconfig: Organize debugging options per file extensions ......................................................................
Patch Set 1:
(1 comment)
I think it's better to add patterns on demand.
https://review.coreboot.org/c/coreboot/+/36616/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/36616/1/src/Kconfig@744 PS1, Line 744: source "src/*/*/*/*/Kconfig.debug_cpu" Use case? This already looks in a lot places where I wouldn't expect CPU options but doesn't look where I'd expect some, e.g. src/soc/intel/common/ block/cpu/.
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36616
to look at the new patch set (#2).
Change subject: Kconfig: Organize debugging options per file extensions ......................................................................
Kconfig: Organize debugging options per file extensions
Change-Id: Ia4553fb4cd95d2f1fa86eecbf382e6e6dec52b92 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/Kconfig R src/cpu/x86/Kconfig.debug_cpu 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36616/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36616 )
Change subject: Kconfig: Organize debugging options per file extensions ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36616 )
Change subject: Kconfig: Organize debugging options per file extensions ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36616/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/36616/1/src/Kconfig@744 PS1, Line 744: source "src/*/*/*/*/Kconfig.debug_cpu"
Use case? This already looks in a lot places where I wouldn't expect CPU […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36616 )
Change subject: Kconfig: Organize debugging options per file extensions ......................................................................
Kconfig: Organize debugging options per file extensions
Change-Id: Ia4553fb4cd95d2f1fa86eecbf382e6e6dec52b92 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36616 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/Kconfig R src/cpu/x86/Kconfig.debug_cpu 2 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 0d56291..2b5f05e 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -738,7 +738,7 @@ menu "Debugging"
comment "CPU Debug Settings" -source "src/cpu/*/Kconfig.debug" +source "src/cpu/*/Kconfig.debug_cpu"
comment "General Debug Settings"
diff --git a/src/cpu/x86/Kconfig.debug b/src/cpu/x86/Kconfig.debug_cpu similarity index 100% rename from src/cpu/x86/Kconfig.debug rename to src/cpu/x86/Kconfig.debug_cpu