Attention is currently required from: Cliff Huang, Martin Roth, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55503 )
Change subject: util/cse_serger: Add a new tool for stitching CSE components ......................................................................
Patch Set 16:
(4 comments)
File util/cbfstool/bpdt_formats/subpart_entry_1.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129914): https://review.coreboot.org/c/coreboot/+/55503/comment/66b62219_70527581 PS16, Line 49: printf("%-25s%-25s%-25s%-25s%-25s%-25s\n", "Entry #", "Name", "Offset", "Huffman Compressed?", line over 96 characters
File util/cbfstool/cse_serger.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129914): https://review.coreboot.org/c/coreboot/+/55503/comment/66c599d7_9c8c4fa7 PS16, Line 64: cse_layout_ptr (*read_layout)(struct buffer *); function definition argument 'struct buffer *' should also have an identifier name
File util/cbfstool/cse_serger.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129914): https://review.coreboot.org/c/coreboot/+/55503/comment/772a85d1_cc075a1c PS16, Line 272: ERROR("Part(%d) exceeds file size. Part offset=0x%x, Part size = 0x%x, File size = 0x%zx\n", line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129914): https://review.coreboot.org/c/coreboot/+/55503/comment/3414fb80_bd8d518d PS16, Line 923: if (c < LONGOPT_START) { braces {} are not necessary for any arm of this statement