Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55854 )
Change subject: soc/amd/common/block/lpc: Add custom SPI DMA boot device
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/common/block/lpc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/55854/comment/c97b0694_7e51fe54
PS1, Line 16: verstage-y += spi_dma.c
It doesn't look like this is set up for psp_verstage. Disable it if psp_verstage is selected?
File src/soc/amd/common/block/lpc/spi_dma.c:
https://review.coreboot.org/c/coreboot/+/55854/comment/be05c274_05a4049f
PS1, Line 34: memcpy(b, &mdev->base[offset], size);
Nit: Maybe add a comment here unless you think the other patches will be merged before long.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id26e2a69601d0f31e256d0010008904a447c8e21
Gerrit-Change-Number: 55854
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 01 Jul 2021 17:38:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment