Attention is currently required from: Marshall Dawson.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84436?usp=email )
Change subject: mb/amd/birman_plus/devicetree_glinda.cb: Update USB ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84436/comment/266b77e6_fe7c5b9f?usp... : PS4, Line 9: Signed-off-by: Satya SreenivasL satya.sreenivasl@amd.com : Change-Id: I0603f5da689b6738ea54305a665b150121bc520c : Reviewed-by: Anand Vaikar a.vaikar2021@gmail.com : Reviewed-by: Ritul Guru ritul.bits@gmail.com : Tested-by: Satya Sreenivas L Satya.SreenivasL@amd.com :
Consider prepending these with "Original-" to keep the git history clean?
Done
File src/mainboard/amd/birman_plus/devicetree_glinda.cb:
https://review.coreboot.org/c/coreboot/+/84436/comment/11b7f6cc_70241fd2?usp... : PS4, Line 140: .txvreftune = 0x6,
3? I'm comparing against AmdCpmPkg/Addendum/Oem/BirmanPlus/AmdCpmPkg.inc. […]
I don't have that source material, but I take your word for it.
https://review.coreboot.org/c/coreboot/+/84436/comment/cdc95214_48b5c313?usp... : PS4, Line 154: .txvreftune = 0x6
3?
same as above.