Change in coreboot[master]: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs for inde...
Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40564 )
Change subject: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs for indentation ......................................................................
util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs for indentation
Newly added code in commit CB:25546 contains spaces instead of TABs for line indent. Replace every 4 spaces by a single TAB to match our coding guides.
Change-Id: Ie3633bb42643f4abb5f1a8827a7dc2c9e023d6aa Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M util/scripts/ucode_h_to_bin.sh 1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/40564/1
diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh index 436c0fd..e6f4699 100755 --- a/util/scripts/ucode_h_to_bin.sh +++ b/util/scripts/ucode_h_to_bin.sh @@ -41,23 +41,23 @@ EOF
include_file() { - if [ "${1: -4}" == ".inc" ]; then - awk '{gsub( /h.*$/, "", $2 ); print "0x" $2 ","; }' "$1" \ - >> "${TMPFILE}.c" - else - echo "#include "$1"" >> "${TMPFILE}.c" - fi + if [ "${1: -4}" == ".inc" ]; then + awk '{gsub( /h.*$/, "", $2 ); print "0x" $2 ","; }' "$1" \ + >> "${TMPFILE}.c" + else + echo "#include "$1"" >> "${TMPFILE}.c" + fi }
for UCODE in "${@:2}"; do - if [ -d "$UCODE" ]; then - for f in "$UCODE/"*.inc - do - include_file "$f" - done - else - include_file "$UCODE" - fi + if [ -d "$UCODE" ]; then + for f in "$UCODE/"*.inc + do + include_file "$f" + done + else + include_file "$UCODE" + fi done
cat >> "${TMPFILE}.c" << EOF
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40564 )
Change subject: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs for indentation ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40564 )
Change subject: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs for indentation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40564/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40564/1//COMMIT_MSG@7 PS1, Line 7: for indentation this is a bit too long, maybe drop?
Hello build bot (Jenkins), Patrick Georgi, Angel Pons, Lev,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40564
to look at the new patch set (#2).
Change subject: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs ......................................................................
util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs
Newly added code in commit CB:25546 contains spaces instead of TABs for line indent. Replace every 4 spaces by a single TAB to match our coding guides.
Change-Id: Ie3633bb42643f4abb5f1a8827a7dc2c9e023d6aa Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M util/scripts/ucode_h_to_bin.sh 1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/40564/2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40564 )
Change subject: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40564/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40564/1//COMMIT_MSG@7 PS1, Line 7: for indentation
this is a bit too long, maybe drop?
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40564 )
Change subject: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs ......................................................................
util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs
Newly added code in commit CB:25546 contains spaces instead of TABs for line indent. Replace every 4 spaces by a single TAB to match our coding guides.
Change-Id: Ie3633bb42643f4abb5f1a8827a7dc2c9e023d6aa Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40564 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/scripts/ucode_h_to_bin.sh 1 file changed, 14 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh index 436c0fd..e6f4699 100755 --- a/util/scripts/ucode_h_to_bin.sh +++ b/util/scripts/ucode_h_to_bin.sh @@ -41,23 +41,23 @@ EOF
include_file() { - if [ "${1: -4}" == ".inc" ]; then - awk '{gsub( /h.*$/, "", $2 ); print "0x" $2 ","; }' "$1" \ - >> "${TMPFILE}.c" - else - echo "#include "$1"" >> "${TMPFILE}.c" - fi + if [ "${1: -4}" == ".inc" ]; then + awk '{gsub( /h.*$/, "", $2 ); print "0x" $2 ","; }' "$1" \ + >> "${TMPFILE}.c" + else + echo "#include "$1"" >> "${TMPFILE}.c" + fi }
for UCODE in "${@:2}"; do - if [ -d "$UCODE" ]; then - for f in "$UCODE/"*.inc - do - include_file "$f" - done - else - include_file "$UCODE" - fi + if [ -d "$UCODE" ]; then + for f in "$UCODE/"*.inc + do + include_file "$f" + done + else + include_file "$UCODE" + fi done
cat >> "${TMPFILE}.c" << EOF
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40564 )
Change subject: util/scripts/ucode_h_to_bin.sh: Replace whitespace with TABs ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2523 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2522 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2521 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2520
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)