Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82578?usp=email )
Change subject: soc/amd/phoenix/chipset_*.cb: remove TODO ......................................................................
soc/amd/phoenix/chipset_*.cb: remove TODO
Remove the TODO to update the chipset devicetree for Phoenix, since this has already been done.
When re-checking the chipset devicetree, I found conflicting information about the existence of the PCI bridge to an external PCIe port on bus 0 device 1 function 5, but after looking into this, I'm reasonably certain that it either doesn't exist or at least wouldn't be usable, so I won't add that one to the chipset devicetree.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I8f0e1540ed45408e86186253d3982a7ba0065ac6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/82578 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com Reviewed-by: Varshit Pandya pandyavarshit@gmail.com --- M src/soc/amd/phoenix/chipset_fsp.cb M src/soc/amd/phoenix/chipset_opensil.cb 2 files changed, 0 insertions(+), 4 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved Varshit Pandya: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/amd/phoenix/chipset_fsp.cb b/src/soc/amd/phoenix/chipset_fsp.cb index 08ee8c2..2d1e170 100644 --- a/src/soc/amd/phoenix/chipset_fsp.cb +++ b/src/soc/amd/phoenix/chipset_fsp.cb @@ -1,5 +1,3 @@ -# TODO: Update for Phoenix - chip soc/amd/phoenix device cpu_cluster 0 on ops amd_cpu_bus_ops diff --git a/src/soc/amd/phoenix/chipset_opensil.cb b/src/soc/amd/phoenix/chipset_opensil.cb index c11975c..0c5cfbc 100644 --- a/src/soc/amd/phoenix/chipset_opensil.cb +++ b/src/soc/amd/phoenix/chipset_opensil.cb @@ -1,5 +1,3 @@ -# TODO: Update for Phoenix - chip soc/amd/phoenix device cpu_cluster 0 on ops amd_cpu_bus_ops