Attention is currently required from: Felix Singer, Frans Hendriks, Harrie Paijmans.
Maxim Polyakov has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
Change subject: superio/fintek: Add support for f81966d
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87198/comment/2619ded6_5b62fe59?usp... :
PS2, Line 16: TEST
Have you checked your updated configuration using util/superiotool?
Do your values match the dump?
File src/superio/fintek/f81966d/f81966d_hwm.c:
https://review.coreboot.org/c/coreboot/+/87198/comment/b68c5867_22b15ba4?usp... :
PS2, Line 29: pnp_write_index
Why don't you use pnp_write_hwm5_index() here?
Maybe I'm wrong, but shouldn't we take into account the HWM offset +5, as superiotool does https://github.com/coreboot/coreboot/blob/main/util/superiotool/fintek.c#L88... ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87198?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Gerrit-Change-Number: 87198
Gerrit-PatchSet: 2
Gerrit-Owner: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Comment-Date: Tue, 08 Apr 2025 12:13:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No