Attention is currently required from: Subrata Banik, Rizwan Qureshi, Arthur Heymans, Patrick Rudolph, Sridhar Siricilla.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62715 )
Change subject: soc/intel/common: Add support to control CSE firmware update
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/62715/comment/5bfdd745_8595c5c7
PS3, Line 34: fmap_locate_area_as_rdev_rw
In this case, fmap_locate_area_as_rdev() can work.
Ack
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/62715/comment/e0ed46a1_f28a0dd7
PS3, Line 1067: * cse firmware update is skipped if SOC_INTEL_CSE_RW_UPDATE is not defined and
: * runtime debug control flag is not enabled.
The comment is not required as code already indicates the same. I will remove it. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f234b142191eb83137d5d83f21e890e1cb828ba
Gerrit-Change-Number: 62715
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@gmail.com
Gerrit-Comment-Date: Fri, 01 Apr 2022 06:40:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@gmail.com
Gerrit-MessageType: comment