[XL] Change in coreboot[main]: soc/intel/xeon_sp: Add GraniteRapids initial codes

[Shuo Liu (Code Review)]

Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, TangYiwei, Tim Chu.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81316?usp=email )

Change subject: soc/intel/xeon_sp: Add GraniteRapids initial codes
......................................................................

Patch Set 5:

(10 comments)

File src/soc/intel/xeon_sp/chip_fsp24.c:

https://review.coreboot.org/c/coreboot/+/81316/comment/a4e242fa_db9574c8 :
PS5, Line 92: map_uid_to_domain_type
> Not needed when the caller passes the correct domain type.

Acknowledged

https://review.coreboot.org/c/coreboot/+/81316/comment/281bce4e_44bab24e :
PS5, Line 95: root
> Not needed when PCI root bridges on the same stack do not use overlapping bus ranges.

Acknowledged

https://review.coreboot.org/c/coreboot/+/81316/comment/75314d75_01730dad :
PS5, Line 118: soc_create_fsp24_domains
> This is wrong. […]

Acknowledged

File src/soc/intel/xeon_sp/gnr/soc_acpi.c:

https://review.coreboot.org/c/coreboot/+/81316/comment/044044f6_5c8a85c7 :
PS5, Line 3: acpigen
> do you need all those headers?

Acknowledged

https://review.coreboot.org/c/coreboot/+/81316/comment/2a43fde9_63794536 :
PS5, Line 57: uncore_fill_ssdt
> removed from main branch

Acknowledged

File src/soc/intel/xeon_sp/gnr/soc_util.c:

https://review.coreboot.org/c/coreboot/+/81316/comment/f6a793c9_1f78bed6 :
PS5, Line 127: sizeof
> ARRAY_SIZE

Acknowledged

File src/soc/intel/xeon_sp/uncore.c:

https://review.coreboot.org/c/coreboot/+/81316/comment/ec0e78cd_f425e3a7 :
PS5, Line 306: )
> soc specific code should be moved out of common code

Acknowledged

https://review.coreboot.org/c/coreboot/+/81316/comment/45b5ccfa_68769002 :
PS5, Line 306: #if CONFIG(PLATFORM_USES_FSP2_4)
             : int soc_add_dram_resources(struct device *dev, int start_index)
             : {
             : 	return 0;
             : }
             : #else
> This is wrong and will mess with other resources.

Could you please specify?

File src/soc/intel/xeon_sp/uncore_acpi.c:

https://review.coreboot.org/c/coreboot/+/81316/comment/f202b845_579ad153 :
PS5, Line 25: MemoryMapDataHob
> unrelated?

used in get_srat_memory_entries

File src/soc/intel/xeon_sp/util.c:

https://review.coreboot.org/c/coreboot/+/81316/comment/f21895ac_d30aa9de :
PS5, Line 24: unlock_pam_regions
> Is it needed at all? I could not figure out what it does or why.

Not sure, if SPR pass without this func, do you agree to remove it?