Change in coreboot[master]: tests: Fix a typo in tests/lib/Makefile.inc

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Anna Karas (Code Review)

12 Jun 2020 12 Jun '20

2:12 p.m.

Anna Karas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests: Fix a typo in tests/lib/Makefile.inc ......................................................................

tests: Fix a typo in tests/lib/Makefile.inc

Fix a typo in a comment in Makefile.inc.

Signed-off-by: Anna Karas aka@semihalf.com Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c --- M tests/lib/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/42312/1

diff --git a/tests/lib/Makefile.inc b/tests/lib/Makefile.inc index 565bb31..61f99bf 100644 --- a/tests/lib/Makefile.inc +++ b/tests/lib/Makefile.inc @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only

-# object filest should be under build/tests/ build/test/src/ build/test/run/ +# object files should be under build/tests/ build/test/src/ build/test/run/ # two examples - first should be simply string.c, second should use -wrap

tests-y += string-test

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

HAOUAS Elyes (Code Review)

12 Jun 12 Jun

3:37 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests: Fix a typo in tests/lib/Makefile.inc ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 1 Gerrit-Owner: Anna Karas aka@semihalf.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 12 Jun 2020 15:37:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

5:51 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests: Fix a typo in tests/lib/Makefile.inc ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 1 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 12 Jun 2020 17:51:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

6:31 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests: Fix a typo in tests/lib/Makefile.inc ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 1 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 12 Jun 2020 18:31:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

7:50 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests: Fix a typo in tests/lib/Makefile.inc ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc File tests/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc@3 PS1, Line 3: # object files should be under build/tests/ build/test/src/ build/test/run/ Is this comment still accurate, anyway? As far as I know object files are under build/tests/<test-subdir>/<test-name>/ now. (I'm also not sure why we have a comment like this in the subdirectory Makefile.inc of some random test... if we want to explain how the test output directory is structured, that should probably go into the main tests/Makefile.inc instead.)

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 1 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 12 Jun 2020 19:50:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

8:20 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests: Fix a typo in tests/lib/Makefile.inc ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42312/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42312/1//COMMIT_MSG@7 PS1, Line 7: tests: Fix a typo in tests/lib/Makefile.inc

...

tests/lib/Makefile.inc: Fix typo in comment

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 1 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 12 Jun 2020 20:20:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jan Dabros (Code Review)

29 Jun 29 Jun

10:57 a.m.

Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests: Fix a typo in tests/lib/Makefile.inc ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc File tests/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc@3 PS1, Line 3: # object files should be under build/tests/ build/test/src/ build/test/run/

...

Is this comment still accurate, anyway? As far as I know object files are under build/tests/<test-su […]

Yeah, I think that there is no value in putting such a comment here. Let's remove this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 1 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jun 2020 10:57:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Anna Karaś (Code Review)

7:12 p.m.

New subject: Change in coreboot[master]: tests/lib/Makefile.inc: remove a comment

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Fagerburg, Julius Werner, Angel Pons, Jan Dabros, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42312

to look at the new patch set (#2).

Change subject: tests/lib/Makefile.inc: remove a comment ......................................................................

tests/lib/Makefile.inc: remove a comment

Remove a comment since is not useful anymore.

Signed-off-by: Anna Karas aka@semihalf.com Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c --- M tests/lib/Makefile.inc 1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/42312/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 2 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Anna Karaś (Code Review)

7:24 p.m.

New subject: Change in coreboot[master]: tests/lib/Makefile.inc: remove a comment

Anna Karaś has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests/lib/Makefile.inc: remove a comment ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42312/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42312/1//COMMIT_MSG@7 PS1, Line 7: tests: Fix a typo in tests/lib/Makefile.inc

...

...
tests/lib/Makefile. […]

Done

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc File tests/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc@3 PS1, Line 3: # object files should be under build/tests/ build/test/src/ build/test/run/

...

Yeah, I think that there is no value in putting such a comment here. Let's remove this.

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 2 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jun 2020 19:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Julius Werner jwerner@chromium.org Comment-In-Reply-To: Jan Dabros jsd@semihalf.com Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

10:05 p.m.

New subject: Change in coreboot[master]: tests/lib/Makefile.inc: remove a comment

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests/lib/Makefile.inc: remove a comment ......................................................................

Patch Set 2: Code-Review+1

For any comments that you have resolved, you should mark them resolved so that we can see which ones are still outstanding.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 2 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jun 2020 22:05:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Anna Karaś (Code Review)

30 Jun 30 Jun

8:49 a.m.

New subject: Change in coreboot[master]: tests/lib/Makefile.inc: remove a comment

Anna Karaś has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests/lib/Makefile.inc: remove a comment ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc File tests/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc@3 PS1, Line 3: # object files should be under build/tests/ build/test/src/ build/test/run/

...

Done.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 2 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 08:49:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anna Karaś aka@semihalf.com Comment-In-Reply-To: Julius Werner jwerner@chromium.org Comment-In-Reply-To: Jan Dabros jsd@semihalf.com Gerrit-MessageType: comment

Julius Werner (Code Review)

9:47 p.m.

New subject: Change in coreboot[master]: tests/lib/Makefile.inc: remove a comment

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests/lib/Makefile.inc: remove a comment ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 2 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 21:47:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 Jul 1 Jul

5:18 a.m.

New subject: Change in coreboot[master]: tests/lib/Makefile.inc: remove a comment

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42312 )

Change subject: tests/lib/Makefile.inc: remove a comment ......................................................................

tests/lib/Makefile.inc: remove a comment

Remove a comment since is not useful anymore.

Signed-off-by: Anna Karas aka@semihalf.com Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Reviewed-on: https://review.coreboot.org/c/coreboot/+/42312 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Julius Werner jwerner@chromium.org --- M tests/lib/Makefile.inc 1 file changed, 0 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve

diff --git a/tests/lib/Makefile.inc b/tests/lib/Makefile.inc index 565bb31..c490317 100644 --- a/tests/lib/Makefile.inc +++ b/tests/lib/Makefile.inc @@ -1,8 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only

-# object filest should be under build/tests/ build/test/src/ build/test/run/ -# two examples - first should be simply string.c, second should use -wrap - tests-y += string-test

string-test-srcs += tests/lib/string-test.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/42312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c Gerrit-Change-Number: 42312 Gerrit-PatchSet: 3 Gerrit-Owner: Anna Karaś aka@semihalf.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1635

days inactive

1654

days old

coreboot-gerrit@coreboot.org

12 comments

9 participants

tags (0)

participants (9)

Angel Pons (Code Review)
Anna Karas (Code Review)
Anna Karaś (Code Review)
HAOUAS Elyes (Code Review)
Jan Dabros (Code Review)
Julius Werner (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)