Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71631 )
Change subject: mb/google/rex: Configure EN_DMIC_SOC_DATA to GPO and LOW
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Who will set it high if there is no driver to control it? IIUC, there is no audio drier will control GPIO.
Reading https://b.corp.google.com/issues/263411621#comment3, I felt the audio driver might have some request in future.
For Proto 1
```
Initial Proto1 build configuration will bypass the DMIC gate via jumpers. Enable signal moved to GPP_H15.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d376f895b2f0882c9fa6fe7b98686907bde4321
Gerrit-Change-Number: 71631
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 07:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment