Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74241 )
Change subject: mb/starlabs/starbook/adl: Correct the number of NID entries ......................................................................
mb/starlabs/starbook/adl: Correct the number of NID entries
The number of NID entries was too high for the Realtek and Intel sound cards, preventing the verb table from loading. Now the values are correct; it loads as intended.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I79825313a4801c120a0a2a321cbabab7c728aa71 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74241 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/adl/hda_verb.c 1 file changed, 19 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/adl/hda_verb.c b/src/mainboard/starlabs/starbook/variants/adl/hda_verb.c index a234de1..c2d10ed 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/hda_verb.c +++ b/src/mainboard/starlabs/starbook/variants/adl/hda_verb.c @@ -7,7 +7,7 @@ /* coreboot specific header */ 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ 0x1e507007, /* Subsystem ID */ - 36, /* Number of jacks (NID entries) */ + 17, /* Number of jacks (NID entries) */
/* Reset Codec First */ AZALIA_RESET(0x1), @@ -54,7 +54,7 @@
0x80862815, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */ - 9, /* Number of 4 dword sets */ + 10, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(2, 0x80860101),