build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support ......................................................................
Patch Set 1:
(15 comments)
File src/ec/starlabs/merlin/acpi/ec.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/2b533af9_781d50e6 PS1, Line 101: Return (Local1) // Return incase Arg0 doesnt exist 'incase' may be misspelled - perhaps 'in case'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/69cd8784_3aaf8ca3 PS1, Line 101: Return (Local1) // Return incase Arg0 doesnt exist 'doesnt' may be misspelled - perhaps 'doesn't'?
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/8f67760f_c976d1df PS1, Line 70: switch (get_uint_option("kbl_timeout", 0)) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/be42203d_7c43ad66 PS1, Line 97: switch (get_uint_option("fn_ctrl_swap", 0)) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/3820dec6_357d053c PS1, Line 115: switch (get_uint_option("max_charge", 0)) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/dcec54a6_6edecf12 PS1, Line 123: ec_write(ECRAM_MAX_CHARGE, CHARGE_100); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/83aa5c9e_d2ad9651 PS1, Line 123: ec_write(ECRAM_MAX_CHARGE, CHARGE_100); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/2447cb1e_3c3ee444 PS1, Line 136: switch (get_uint_option("fan_mode", 0)) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/f367ce46_af1925ab PS1, Line 157: switch (get_uint_option("fn_lock_state", 0)) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/c3b9180f_e4b8d656 PS1, Line 175: switch (get_uint_option("trackpad_state", 0)) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/d08149b0_3ff10372 PS1, Line 193: switch (get_uint_option("kbl_brightness", 0)) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/4ed2c05c_b2810207 PS1, Line 220: switch (get_uint_option("kbl_state", 0)) { switch and case should be at the same indent
File src/ec/starlabs/merlin/variants/merlin/emem.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/80200b0e_7f9b5e4d PS1, Line 45: KLTE, 8, // Keyboard Backlight Timeout trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/19b5620a_1be796a0 PS1, Line 46: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130452): https://review.coreboot.org/c/coreboot/+/58343/comment/fa8b9d2a_a79d7d3f PS1, Line 48: SHIP, 8, // Shipping Mode Flag trailing whitespace
-
build bot (Jenkins) (Code Review)