Attention is currently required from: Christian Walter, Angel Pons, Arthur Heymans. Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58879 )
Change subject: mb/prodrive/hermes: Configure pink rear vref based on eeprom ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1: Looks good
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/58879/comment/9b7e5741_d15624d4 PS1, Line 82: const u32 internal_config = get_internal_audio_cfg(board_cfg->internal_audio_connection);
line over 96 characters […]
actually, you can name it front_panel. Customer asked for more clear setting name
https://review.coreboot.org/c/coreboot/+/58879/comment/c9455e97_7f617057 PS1, Line 89: get_port_c_vref_cfg(board_cfg->blue_rear_vref),
Hmmm, this one is probably wrong then
No, this one uses some kind of hidden register in the codec. Realtek provided the registers here