Attention is currently required from: Michał Kopeć.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62493 )
Change subject: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Having the device at _SB. […]
On Xeon-Sp the scope _SB.PCI0 doesn't exist. If hardcoded it should be scope _SB.
MSDN specifies that this has to be in DSDT, but we are currently placing it in SSDT.
Maybe that makes a difference?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62493
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0b3136e3eb8eb1bb132132a5f3a7034bdd3b424
Gerrit-Change-Number: 62493
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 08:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment