Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Martin L Roth, Nick Vaccaro, Nico Huber, Subrata Banik, srinivas.kulkarni@intel.com.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81080?usp=email )
Change subject: soc/intel/alderlake: Correctly set CNVi Reset and Clkreq pins
......................................................................
Patch Set 5:
(3 comments)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81080/comment/7796d9f7_4b65ea9d :
PS4, Line 837: * which are used for eSPI.
`... hence we need to switch to GPP_F4 and GPP_F5`. […]
Done
https://review.coreboot.org/c/coreboot/+/81080/comment/b332d9de_3c2e4c76 :
PS4, Line 840: 2
The comment in `Fsps_Upd. […]
Yeah - looks like a copy/paste from TGL
https://review.coreboot.org/c/coreboot/+/81080/comment/27f81219_1ba9646d :
PS4, Line 838:
: s_cfg->CnviRfResetPinMux = 0x194ce404;
: s_cfg->CnviClkreqPinMux = 0x294ce605;
Comments in `Fsps_Upd.h` suggest that both should be 0 for ADL-S which […]
Done (SBL and AMI set them for S too, but guard is good as I doubt anyone would make that combo)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81080?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib534d3cfe888c1c538267caaf324c8ae743da496
Gerrit-Change-Number: 81080
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: srinivas.kulkarni@intel.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: srinivas.kulkarni@intel.com
Gerrit-Comment-Date: Tue, 19 Mar 2024 19:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment