Change in coreboot[master]: mb/google/volteer/halvor: Enable cardreader function on Halvor
Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable cardreader function on Halvor ......................................................................
mb/google/volteer/halvor: Enable cardreader function on Halvor
Configure gpio settings for enabling cardreader function.
BUG=b:153680359 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that the sd card is mount on /dev/mmcblk0 successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I51752f47bc8d31d3a11da728ce00ca754381fde9 --- M src/mainboard/google/volteer/variants/halvor/gpio.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/44169/1
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c index 2a98688..50506d0 100644 --- a/src/mainboard/google/volteer/variants/halvor/gpio.c +++ b/src/mainboard/google/volteer/variants/halvor/gpio.c @@ -56,6 +56,8 @@
/* D7 : SRCCLKREQ2# ==> NC */ PAD_NC(GPP_D7, NONE), + /* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL */ + PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* D9 : ISH_SPI_CS# ==> TBT_LSX2_TXD */ PAD_CFG_NF(GPP_D9, NONE, DEEP, NF4), /* D10 : ISH_SPI_CLK ==> TBT_LSX2_RXD */ @@ -64,6 +66,8 @@ PAD_NC(GPP_D11, NONE), /* D12 : ISH_SPI_MOSI ==> NC */ PAD_NC(GPP_D12, NONE), + /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP),
/* E0 : SATAXPCIE0 ==> NC */ PAD_NC(GPP_E0, NONE), @@ -75,6 +79,8 @@ PAD_NC(GPP_E5, NONE), /* E10 : SPI1_CS# ==> NC */ PAD_NC(GPP_E10, NONE), + /* E11 : SPI1_CLK ==> SD_PE_WAKE_ODL */ + PAD_CFG_GPI(GPP_E11, NONE, DEEP), /* E12 : SPI1_MISO_IO1 ==> NC */ PAD_NC(GPP_E12, NONE), /* E13 : SPI1_MOSI_IO0 ==> NC */ @@ -109,6 +115,8 @@ /* F19 : SRCCLKREQ6# ==> NC */ PAD_NC(GPP_F19, NONE),
+ /* H3 : SX_EXIT_HOLDOFF# ==> SD_PERST_L */ + PAD_CFG_GPO(GPP_H3, 1, DEEP), /* H6 : I2C3_SDA */ PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), /* H7 : I2C3_SCL */ @@ -184,6 +192,9 @@ /* C22 : UART2_RTS# ==> PCH_FPMCU_BOOT0 */ PAD_CFG_GPO(GPP_C22, 0, DEEP),
+ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), + /* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */ PAD_CFG_GPO(GPP_H11, 1, DEEP), };
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable cardreader function on Halvor ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44169/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44169/1//COMMIT_MSG@7 PS1, Line 7: mb/google/volteer/halvor: Enable cardreader function on Halvor card reader
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee... PS1, Line 196: PAD_CFG_GPO(GPP_D16, 1, DEEP), Do we need this in early table?
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Angel Pons, Nick Vaccaro, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44169
to look at the new patch set (#2).
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
mb/google/volteer/halvor: Enable card reader function on Halvor
Configure gpio settings for enabling card reader function.
BUG=b:153680359 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that the sd card is mount on /dev/mmcblk0 successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I51752f47bc8d31d3a11da728ce00ca754381fde9 --- M src/mainboard/google/volteer/variants/halvor/gpio.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/44169/2
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44169/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44169/1//COMMIT_MSG@7 PS1, Line 7: mb/google/volteer/halvor: Enable cardreader function on Halvor
card reader
Done
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee... PS1, Line 196: PAD_CFG_GPO(GPP_D16, 1, DEEP),
Do we need this in early table?
Here is the reference. https://review.coreboot.org/c/coreboot/+/43988
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee... PS1, Line 196: PAD_CFG_GPO(GPP_D16, 1, DEEP),
Here is the reference. […]
Sorry for the wrong link.
Update the correct one: https://review.coreboot.org/c/coreboot/+/44117
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
Patch Set 2: Code-Review+1
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
Patch Set 2: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
Patch Set 2: Code-Review+2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
Patch Set 2: Code-Review+2
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
Patch Set 2:
Hi Tim and Google,
Would you help to merge the CL? We would like to have CPFE FW for further action. Thank you very much.
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor ......................................................................
mb/google/volteer/halvor: Enable card reader function on Halvor
Configure gpio settings for enabling card reader function.
BUG=b:153680359 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that the sd card is mount on /dev/mmcblk0 successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I51752f47bc8d31d3a11da728ce00ca754381fde9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44169 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Caveh Jalali caveh@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/halvor/gpio.c 1 file changed, 11 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved EricR Lai: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c index 1cbe62d..09e8081 100644 --- a/src/mainboard/google/volteer/variants/halvor/gpio.c +++ b/src/mainboard/google/volteer/variants/halvor/gpio.c @@ -58,6 +58,8 @@
/* D7 : SRCCLKREQ2# ==> NC */ PAD_NC(GPP_D7, NONE), + /* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL */ + PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* D9 : ISH_SPI_CS# ==> TBT_LSX2_TXD */ PAD_CFG_NF(GPP_D9, NONE, DEEP, NF4), /* D10 : ISH_SPI_CLK ==> TBT_LSX2_RXD */ @@ -66,6 +68,8 @@ PAD_NC(GPP_D11, NONE), /* D12 : ISH_SPI_MOSI ==> NC */ PAD_NC(GPP_D12, NONE), + /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP),
/* E0 : SATAXPCIE0 ==> NC */ PAD_NC(GPP_E0, NONE), @@ -77,6 +81,8 @@ PAD_NC(GPP_E5, NONE), /* E10 : SPI1_CS# ==> NC */ PAD_NC(GPP_E10, NONE), + /* E11 : SPI1_CLK ==> SD_PE_WAKE_ODL */ + PAD_CFG_GPI(GPP_E11, NONE, DEEP), /* E12 : SPI1_MISO_IO1 ==> NC */ PAD_NC(GPP_E12, NONE), /* E13 : SPI1_MOSI_IO0 ==> NC */ @@ -113,6 +119,8 @@ /* F19 : SRCCLKREQ6# ==> NC */ PAD_NC(GPP_F19, NONE),
+ /* H3 : SX_EXIT_HOLDOFF# ==> SD_PERST_L */ + PAD_CFG_GPO(GPP_H3, 1, DEEP), /* H6 : I2C3_SDA */ PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), /* H7 : I2C3_SCL */ @@ -188,6 +196,9 @@ /* C22 : UART2_RTS# ==> PCH_FPMCU_BOOT0 */ PAD_CFG_GPO(GPP_C22, 0, DEEP),
+ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), + /* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */ PAD_CFG_GPO(GPP_H11, 1, DEEP), };
-
Angel Pons (Code Review) -
Caveh Jalali (Code Review)
-
EricR Lai (Code Review)
-
Frank Wu (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)