Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19781 )
Change subject: drivers/spi/spi-generic: Make spi_setup_slave strong symbol
......................................................................
Patch Set 4:
I was wondering that. We're unconditionally adding spi-generic.c to all the builds. Should we add a NO_SPI Kconfig that will help guard the spi-generic calls?
Yeah, I think we would need something like that.
--
To view, visit
https://review.coreboot.org/19781
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b9bbb5303dad7ce062958a0ab8dee49a4ec1e0
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: No