Change in coreboot[master]: drivers/i2c/tpm: Work around missing firmware_version in Ti50 < 0.0.15 - coreboot-gerrit

9 May 2022


      Attention is currently required from: Jes Klinke, Reka Norman, Tim Wawrzynczak, Christian Walter, Jett Rink.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64202 )
Change subject: drivers/i2c/tpm: Work around missing firmware_version in Ti50 < 0.0.15
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: 
I think it would make more sense to implement this inside cr50_get_firmware_version() and just return a fake version number (i.e. 0.0.12). Also the Kconfig should probably be in src/security/tpm/tss/vendor/cr50/Kconfig, and I would suggest a more descriptive name ("old" can mean anything)... maybe TPM_TI50_MOCK_VERSION_NUMBER?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64202
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia30d44ac231c42eba3ffb1cb1e6d83bb6593f926
Gerrit-Change-Number: 64202
Gerrit-PatchSet: 2
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jes Klinke jbk@chromium.org
Gerrit-Reviewer: Jett Rink jettrink@chromium.org
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Reka Norman rekanorman@google.com
Gerrit-Attention: Jes Klinke jbk@chromium.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Jett Rink jettrink@chromium.org
Gerrit-Comment-Date: Mon, 09 May 2022 23:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment