HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46075 )
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
mb/aopen: Convert to ASL 2.0 syntax
Change-Id: Ib473121acfc0e985d4c0debecffdc1efbd9c3d66 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl M src/mainboard/aopen/dxplplusu/acpi/i82801db.asl 2 files changed, 26 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46075/1
diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl index 7216d33..dd8689b 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl @@ -36,26 +36,26 @@ CreateQWordField (MSBF, _SB.MBRS._Y1C._MAX, MEMM) CreateQWordField (MSBF, _SB.MBRS._Y1C._LEN, LELM)
- And (_SB.PCI0.RLAR, 0x03FF, Local1) - Increment (Local1) - If (LGreater (Local1, 0x40)) + Local1 = _SB.PCI0.RLAR & 0x03FF + Local1++ + If (Local1 > 0x40) { - ShiftLeft (Local1, 0x1A, LELM) + LELM = Local1 << 26 }
CreateDWordField (MSBF, _SB.MBRS._Y1D._MIN, MS00) CreateDWordField (MSBF, _SB.MBRS._Y1D._MAX, MS01) CreateDWordField (MSBF, _SB.MBRS._Y1D._LEN, MEM2) - And (_SB.PCI0.TOLM, 0xF800, Local1) - ShiftRight (Local1, 0x04, Local1) - Decrement (Local1) - If (LGreater (Local1, 0x10)) + Local1 = _SB.PCI0.TOLM & 0xF800 + Local1 >>= 4 + Local1-- + If (Local1 > 0x10) { - Subtract (Local1, 0x0F, Local1) - Store (ShiftLeft (Local1, 0x14), MEM2) - Store (0x01000000, MS00) - Store (MS00, MS01) + Local1 -= 15 + MEM2 = Local1 << 20 + MS00 = 0x01000000 + MS01 = MS00 }
Return (MSBF) diff --git a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl index 20400c3..4c91abc 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl @@ -112,29 +112,29 @@ CreateWordField (MSBF, _SB_.PCI0.ICH0.PMIO._MAX, IOA2) CreateByteField (MSBF, _SB_.PCI0.ICH0.PMIO._LEN, IOAL)
- Store (PBAR, Local0) - If ( Land(Local0, 0x01) ) + Local0 = PBAR + If (Local0 & 0x01) { - And (Local0, 0xFFFE, Local0) - Store (Local0, IOA1) - Store (Local0, IOA2) - Store (0x80, IOAL) + Local0 &= 0xFFFE + IOA1 = Local0 + IOA2 = Local0 + IOAL = 0x80 } Else { - Store (0x00, IOAL) + IOAL = 0x00 }
CreateWordField (MSBF, _SB_.PCI0.ICH0.GPIO._MIN, IOS1) CreateWordField (MSBF, _SB_.PCI0.ICH0.GPIO._MAX, IOS2) CreateByteField (MSBF, _SB_.PCI0.ICH0.GPIO._LEN, IOSL)
- Store (GBAR, Local0) - If ( Land(Local0, 0x01) ) { - And (Local0, 0xFFFE, Local0) - Store (Local0, IOS1) - Store (Local0, IOS2) - Store (0x40, IOSL) + Local0 = GBAR + If (Local0 & 0x01) { + Local0 &= 0xFFFE + IOS1 = Local0 + IOS2 = Local0 + IOSL = 0x40 } Else { - Store (0x00, IOSL) + IOSL = 0x00 } Return (MSBF) }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46075
to look at the new patch set (#2).
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
mb/aopen: Convert to ASL 2.0 syntax
Generated build/dsdt.dsl files are same.
Change-Id: Ib473121acfc0e985d4c0debecffdc1efbd9c3d66 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl M src/mainboard/aopen/dxplplusu/acpi/i82801db.asl 2 files changed, 26 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46075/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46075
to look at the new patch set (#3).
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
mb/aopen: Convert to ASL 2.0 syntax
Generated build/dsdt.dsl files are same.
Change-Id: Ib473121acfc0e985d4c0debecffdc1efbd9c3d66 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl M src/mainboard/aopen/dxplplusu/acpi/i82801db.asl M src/mainboard/aopen/dxplplusu/acpi/superio.asl 3 files changed, 80 insertions(+), 80 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46075/3
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46075 )
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl:
https://review.coreboot.org/c/coreboot/+/46075/comment/dfadb26c_7b00e993 PS4, Line 39: FF lowercase ;) (maybe for the whole branch, then we get the patches in faster :P)
Attention is currently required from: Michael Niewöhner. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46075 )
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: Thank you
File src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl:
https://review.coreboot.org/c/coreboot/+/46075/comment/aed06739_2f0bac9e PS4, Line 39: FF
lowercase ;) (maybe for the whole branch, then we get the patches in faster :P)
Done
Attention is currently required from: Michael Niewöhner. Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46075
to look at the new patch set (#5).
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
mb/aopen: Convert to ASL 2.0 syntax
Generated build/dsdt.dsl files are same.
Change-Id: Ib473121acfc0e985d4c0debecffdc1efbd9c3d66 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl M src/mainboard/aopen/dxplplusu/acpi/i82801db.asl M src/mainboard/aopen/dxplplusu/acpi/superio.asl 3 files changed, 80 insertions(+), 80 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46075/5
Attention is currently required from: Michael Niewöhner, HAOUAS Elyes. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46075 )
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/aopen/dxplplusu/acpi/i82801db.asl:
https://review.coreboot.org/c/coreboot/+/46075/comment/e25ec3db_48fd0630 PS5, Line 116: If (Local0 && 0x01) Looks like original was wrong, bitwise and would make sense here. I'll rebase and push a fix.
https://review.coreboot.org/c/coreboot/+/46075/comment/a4cacacd_2eb8ff38 PS5, Line 131: If (Local0 && 0x01) { as above
Attention is currently required from: Michael Niewöhner, Kyösti Mälkki. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46075 )
Change subject: mb/aopen: Convert to ASL 2.0 syntax ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/aopen/dxplplusu/acpi/i82801db.asl:
https://review.coreboot.org/c/coreboot/+/46075/comment/b4a80947_ddedde21 PS5, Line 116: If (Local0 && 0x01)
Looks like original was wrong, bitwise and would make sense here. I'll rebase and push a fix.
yes please. Thank you.
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Michael Niewöhner (Code Review)