Change in coreboot[master]: mb/google/hatch: Enable Override DLLs for Kindred

[Jamie Chen (Code Review)]

Jamie Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35094 )

Change subject: mb/google/hatch: Enable Override DLLs for Kindred
......................................................................

mb/google/hatch: Enable Override DLLs for Kindred

Enable SOC_INTEL_COMMON_MMC_OVERRIDE for Kindred

BUG=b:136784418
BRANCH=none
TEST=Boot to OS 100 times on Kindred proto 1 board.

Change-Id: I390d237b9119ae42f4b0bb802bf9857552af78bf
Signed-off-by: Jamie Chen 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/35094/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 5c7c267..fc2dae3 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -122,4 +122,8 @@
    select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
    select VBOOT_LID_SWITCH

+config SOC_INTEL_COMMON_MMC_OVERRIDE
+	bool
+	default y if BOARD_GOOGLE_KINDRED
+
 endif # BOARD_GOOGLE_BASEBOARD_HATCH

[Jamie Chen (Code Review)]

Hello Subrata Banik, Kane Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35094

to look at the new patch set (#4).

Change subject: mb/google/hatch: Enable Override DLLs for Kindred
......................................................................

mb/google/hatch: Enable Override DLLs for Kindred

Enable SOC_INTEL_COMMON_MMC_OVERRIDE for Kindred

BUG=b:136784418
BRANCH=none
TEST=Boot to OS 100 times on Kindred proto 1 board.

Change-Id: I390d237b9119ae42f4b0bb802bf9857552af78bf
Signed-off-by: Jamie Chen 
---
M src/mainboard/google/hatch/Kconfig.name
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/35094/4

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35094 )

Change subject: mb/google/hatch: Enable Override DLLs for Kindred
......................................................................

Patch Set 6: Code-Review+2

this can also be squashed into previous CL since it basically is enabling the same thing.

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35094 )

Change subject: mb/google/hatch: Enable Override DLLs for Kindred
......................................................................

Patch Set 8:
> Patch Set 6: Code-Review+2
>
> this can also be squashed into previous CL since it basically is enabling the same thing.

thanks for the suggestion.
I think we can simply revert this "Kconfig enable" change once the newer fsp is landed 
In doing so, we can still have dll setting in dev tree feed into UPDs.
So, we would like to keep this change separate.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35094 )

Change subject: mb/google/hatch: Enable Override DLLs for Kindred
......................................................................

Patch Set 8:
> Patch Set 8:
> > Patch Set 6: Code-Review+2
> >
> > this can also be squashed into previous CL since it basically is enabling the same thing.
>
> thanks for the suggestion.
> I think we can simply revert this "Kconfig enable" change once the newer fsp is landed 
> In doing so, we can still have dll setting in dev tree feed into UPDs.
> So, we would like to keep this change separate.

Okay. Makes sense.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35094 )

Change subject: mb/google/hatch: Enable Override DLLs for Kindred
......................................................................

Patch Set 8:
> Patch Set 8:
> > Patch Set 8:
> > > Patch Set 6: Code-Review+2
> > >
> > > this can also be squashed into previous CL since it basically is enabling the same thing.
> >
> > thanks for the suggestion.
> > I think we can simply revert this "Kconfig enable" change once the newer fsp is landed 
> > In doing so, we can still have dll setting in dev tree feed into UPDs.
> > So, we would like to keep this change separate.
>
> Okay. Makes sense.

yes, thats the reason, i have asked to have dedicated Kconfig to turn on/off based on need. its good that we have common code to handle such DLL override if required

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35094 )

Change subject: mb/google/hatch: Enable Override DLLs for Kindred
......................................................................

mb/google/hatch: Enable Override DLLs for Kindred

Enable SOC_INTEL_COMMON_MMC_OVERRIDE for Kindred

BUG=b:136784418
BRANCH=none
TEST=Boot to OS 100 times on Kindred proto 1 board.

Change-Id: I390d237b9119ae42f4b0bb802bf9857552af78bf
Signed-off-by: Jamie Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35094
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/hatch/Kconfig.name
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name
index e8748e3..85037d9 100644
--- a/src/mainboard/google/hatch/Kconfig.name
+++ b/src/mainboard/google/hatch/Kconfig.name
@@ -23,6 +23,7 @@
    select BOARD_GOOGLE_BASEBOARD_HATCH
    select BOARD_ROMSIZE_KB_16384
    select SOC_INTEL_COMETLAKE
+	select SOC_INTEL_COMMON_MMC_OVERRIDE

config BOARD_GOOGLE_HELIOS
    bool "->  Helios"