Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41128 )
Change subject: soc/amd/picasso: fix iomap for ACPI_PM
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/41128/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41128/2//COMMIT_MSG@9
PS2, Line 9: offsets for ACPI_PM are incorrectly configured for picasso SoC.
It seems that confs are copied from stoneyridge files. I checked with picasso datasheet.
Done
https://review.coreboot.org/c/coreboot/+/41128/2/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/iomap.h:
PS2:
15.1. […]
finally got around to look into this; looks good to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6adf71479c30f5b6751a21edc4bfa311ddbef5ec
Gerrit-Change-Number: 41128
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jun 2020 15:02:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment