Change in ...coreboot[master]: ec/lenovo/h8/Kconfig: increase ps2 timeout from 3000 to 5000ms
Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31279
Change subject: ec/lenovo/h8/Kconfig: increase ps2 timeout from 3000 to 5000ms ......................................................................
ec/lenovo/h8/Kconfig: increase ps2 timeout from 3000 to 5000ms
On my Thinkpad T420 the default 3000ms SeaBIOS timeout is too short, it takes nearly 5000ms for my keyboard to become ready.
Timing out before it's ready leads to pretty bad behavior: I cannot use my keyboard at all to control SeaBIOS, nor the subsequent GRUB instance. (Linux is fine though, probably because it does its own keyboard init)
Signed-off-by: Michael Bacarella michael.bacarella@gmail.com Change-Id: Id1681bf3921c8b5dc124d4c4e9072f146f84f3a2 --- M src/ec/lenovo/h8/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/31279/1
diff --git a/src/ec/lenovo/h8/Kconfig b/src/ec/lenovo/h8/Kconfig index f9b0b14..9df60de 100644 --- a/src/ec/lenovo/h8/Kconfig +++ b/src/ec/lenovo/h8/Kconfig @@ -7,7 +7,7 @@ config SEABIOS_PS2_TIMEOUT int depends on PAYLOAD_SEABIOS - default 3000 + default 5000
config H8_BEEP_ON_DEATH bool "Beep on fatal error"
Hello Alexander Couzens,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31279
to look at the new patch set (#2).
Change subject: ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms ......................................................................
ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms
On my Thinkpad T420 the default 3000ms SeaBIOS timeout is too short, it takes nearly 5000ms for my keyboard to become ready.
Timing out before it's ready leads to pretty bad behavior: I cannot use my keyboard at all to control SeaBIOS, nor the subsequent GRUB instance. (Linux is fine though, probably because it does its own keyboard init)
Signed-off-by: Michael Bacarella michael.bacarella@gmail.com Change-Id: Id1681bf3921c8b5dc124d4c4e9072f146f84f3a2 --- M src/ec/lenovo/h8/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/31279/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31279 )
Change subject: ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
It also should not affect current installations, as it’s the maximum time-out. That means, if keyboard is initialized at two seconds, it will still initialize after two seconds.
https://review.coreboot.org/#/c/31279/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31279/2//COMMIT_MSG@13 PS2, Line 13: nor the subsequent GRUB instance. : (Linux is fine though, probably because it does its own keyboard init) Indeed, GRUB (for PC) in the MBR depends on the BIOS calls.
https://review.coreboot.org/#/c/31279/2//COMMIT_MSG@14 PS2, Line 14: Linux is fine though, probably because it does its own keyboard init Please add a dot/period at the end of sentences.
Hello Alexander Couzens, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31279
to look at the new patch set (#3).
Change subject: ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms ......................................................................
ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms
On my Thinkpad T420 the default 3000ms SeaBIOS timeout is too short, it takes nearly 5000ms for my keyboard to become ready.
Timing out before it's ready leads to pretty bad behavior: I cannot use my keyboard at all to control SeaBIOS, nor the subsequent GRUB instance. Linux is fine though, possibly because it does its own keyboard init.
Signed-off-by: Michael Bacarella michael.bacarella@gmail.com Change-Id: Id1681bf3921c8b5dc124d4c4e9072f146f84f3a2 --- M src/ec/lenovo/h8/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/31279/3
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31279 )
Change subject: ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31279 )
Change subject: ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31279 )
Change subject: ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms ......................................................................
ec/lenovo/h8/Kconfig: increase ps2 kbd timeout from 3000 to 5000ms
On my Thinkpad T420 the default 3000ms SeaBIOS timeout is too short, it takes nearly 5000ms for my keyboard to become ready.
Timing out before it's ready leads to pretty bad behavior: I cannot use my keyboard at all to control SeaBIOS, nor the subsequent GRUB instance. Linux is fine though, possibly because it does its own keyboard init.
Signed-off-by: Michael Bacarella michael.bacarella@gmail.com Change-Id: Id1681bf3921c8b5dc124d4c4e9072f146f84f3a2 Reviewed-on: https://review.coreboot.org/c/31279 Reviewed-by: Alexander Couzens lynxis@fe80.eu Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/lenovo/h8/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Alexander Couzens: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/ec/lenovo/h8/Kconfig b/src/ec/lenovo/h8/Kconfig index f9b0b14..9df60de 100644 --- a/src/ec/lenovo/h8/Kconfig +++ b/src/ec/lenovo/h8/Kconfig @@ -7,7 +7,7 @@ config SEABIOS_PS2_TIMEOUT int depends on PAYLOAD_SEABIOS - default 3000 + default 5000
config H8_BEEP_ON_DEATH bool "Beep on fatal error"
-
Alexander Couzens (Code Review) -
Angel Pons (Code Review)
-
Michael Bacarella (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)