Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19067 )
Change subject: cpu/intel/model_106cx: Add tsc_freq_mhz() function ......................................................................
Patch Set 1:
(2 comments)
Maybe it is better to use MCHBAR(CLKCFG) since that one actually reflects BSEL straps. Not sure if physically possible on these CPUs but for instance on LGA775 BSEL straps can modified in some cases...
https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/Makefile.i... File src/cpu/intel/model_106cx/Makefile.inc:
PS1, Line 5: romstage-y += tsc_freq.c : smm-y += tsc_freq.c
Does it have any effect on these stages?
Not sure. I just copied it from other Intel Makefile.inc.
https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/tsc_freq.c File src/cpu/intel/model_106cx/tsc_freq.c:
This looks the same as `model_1067x/fsc_freq.c`. But right now, no
you mean model_2065x ?
-
Arthur Heymans (Code Review)