Change in coreboot[master]: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39579 )
Change subject: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39579/1/src/soc/intel/apollolake/ch... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/39579/1/src/soc/intel/apollolake/ch... PS1, Line 637: silconfig->Gmm = dev ? dev->enabled : 0;
I’d explicitly check for `dev == NULL`, and print an error.
I am not sure if adding an error print here is really correct. This device is not added to any of the current GLK boards. Also, I don't think it is necessary to add it since those don't care about the device. So, adding an error print means all the current boards without this device would start logging an error which is not really appropriate for that board.
-
Furquan Shaikh (Code Review)