Change in coreboot[master]: soc/mediatek/mt8195: Initialize watchdog - coreboot-gerrit

21 Apr 2021


      Attention is currently required from: Martin Roth, Rex-BC Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52542 )
Change subject: soc/mediatek/mt8195: Initialize watchdog
......................................................................
Patch Set 3:
(2 comments)
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/52542/comment/5fd4f765_e3dd3477 
PS3, Line 12: Mode
Do we need to capitalize it?
File src/soc/mediatek/mt8195/Kconfig:
https://review.coreboot.org/c/coreboot/+/52542/comment/803b9843_58196a99 
PS3, Line 9: SOC_MEDIATEK_COMMON
MEDIATEK_DRAM_DVFS_LIMIT_FREQ_CNT will also be selected. Is it intended?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba5b41f426fc38719bb343a220e0724bff229c79
Gerrit-Change-Number: 52542
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 03:45:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment