Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42016 )
Change subject: util: Allow overriding gcc as default host compiler ......................................................................
util: Allow overriding gcc as default host compiler
BUG=chromium:1088209 TEST=emerge coreboot-utils (with patches to the ebuild) works
Signed-off-by: Patrick Georgi pgeorgi@google.com Change-Id: I25d237d048e417f4e412583031905ecf3614c431 --- M util/ifdtool/Makefile M util/nvramtool/Makefile 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/42016/1
diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index d70080d..e8d818c 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -4,7 +4,7 @@
PROGRAM = ifdtool
-CC = gcc +CC ?= gcc INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -Werror diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index 25962ef..0d7f687 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -8,7 +8,7 @@
PROGRAM = nvramtool
-CC = gcc +CC ?= gcc INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -I. -DCMOS_HAL=1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42016 )
Change subject: util: Allow overriding gcc as default host compiler ......................................................................
Patch Set 1: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42016 )
Change subject: util: Allow overriding gcc as default host compiler ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42016 )
Change subject: util: Allow overriding gcc as default host compiler ......................................................................
util: Allow overriding gcc as default host compiler
BUG=chromium:1088209 TEST=emerge coreboot-utils (with patches to the ebuild) works
Signed-off-by: Patrick Georgi pgeorgi@google.com Change-Id: I25d237d048e417f4e412583031905ecf3614c431 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42016 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/ifdtool/Makefile M util/nvramtool/Makefile 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index d70080d..e8d818c 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -4,7 +4,7 @@
PROGRAM = ifdtool
-CC = gcc +CC ?= gcc INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -Werror diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index 25962ef..0d7f687 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -8,7 +8,7 @@
PROGRAM = nvramtool
-CC = gcc +CC ?= gcc INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -I. -DCMOS_HAL=1
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42016 )
Change subject: util: Allow overriding gcc as default host compiler ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4844 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4843 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4842 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4841
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)