[S] Change in coreboot[main]: soc/intel/[tiger|cannon|meteor]lake: Fix uninitialized usb_cfg pointer

[Jon Murphy (Code Review)]

Jon Murphy has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85026?usp=email )

Change subject: soc/intel/[tiger|cannon|meteor]lake: Fix uninitialized usb_cfg pointer
......................................................................

soc/intel/[tiger|cannon|meteor]lake: Fix uninitialized usb_cfg pointer

This patch addresses uninitialized usb_cfg pointer warning which is also
an error - src/soc/intel/meteorlake/fsp_params.c: error: 'usb_cfg' may
be used uninitialized in this function [-Werror=maybe-uninitialized]

BUG=None
TEST=./util/abuild/abuild for GOOGLE_HATCH, GOOGLE_VOLTEER, GOOGLE_KARIS

Change-Id: I169b6d3a979c4db78e7c0932a126d8b0a9306da7
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85026
Reviewed-by: Jon Murphy 
Tested-by: build bot (Jenkins) 
Reviewed-by: Subrata Banik 
Reviewed-by: Julius Werner 
---
M src/soc/intel/cannonlake/fsp_params.c
M src/soc/intel/meteorlake/fsp_params.c
M src/soc/intel/tigerlake/fsp_params.c
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Jon Murphy: Looks good to me, approved
  Subrata Banik: Looks good to me, approved
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index bd3d149..df5fcee 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -531,7 +531,7 @@
    /* Enable CNVi Wifi if enabled in device tree */
 #if CONFIG(SOC_INTEL_COMETLAKE)
    struct device *port = NULL;
-	struct drivers_usb_acpi_config *usb_cfg;
+	struct drivers_usb_acpi_config *usb_cfg = NULL;
    bool usb_audio_offload = false;

/* Search through the devicetree for matching USB devices */
@@ -564,7 +564,7 @@
    if (s_cfg->CnviBtAudioOffload && !usb_audio_offload) {
    	printk(BIOS_WARNING, "CNVi BT Audio offload enabled but not in USB driver.\n");
    }
-	if (!s_cfg->CnviBtAudioOffload && usb_audio_offload) {
+	if (!s_cfg->CnviBtAudioOffload && usb_cfg && usb_audio_offload) {
    	printk(BIOS_ERR, "USB BT Audio offload enabled but CNVi BT offload disabled\n");
    	usb_cfg->cnvi_bt_audio_offload = 0;
    }
diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c
index c2770e6..0ae36e6 100644
--- a/src/soc/intel/meteorlake/fsp_params.c
+++ b/src/soc/intel/meteorlake/fsp_params.c
@@ -578,7 +578,7 @@
    	const struct soc_intel_meteorlake_config *config)
 {
    struct device *port = NULL;
-	struct drivers_usb_acpi_config *usb_cfg;
+	struct drivers_usb_acpi_config *usb_cfg = NULL;
    bool usb_audio_offload = false;

/* Search through the devicetree for matching USB devices */
@@ -615,7 +615,7 @@
    if (s_cfg->CnviBtAudioOffload && !usb_audio_offload) {
    	printk(BIOS_WARNING, "CNVi BT Audio offload enabled but not in USB driver\n");
    }
-	if (!s_cfg->CnviBtAudioOffload && usb_audio_offload) {
+	if (!s_cfg->CnviBtAudioOffload && usb_cfg && usb_audio_offload) {
    	printk(BIOS_ERR, "USB BT Audio offload enabled but CNVi BT offload disabled\n");
    	usb_cfg->cnvi_bt_audio_offload = 0;
    }
diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c
index 9706ac6..fa95e47 100644
--- a/src/soc/intel/tigerlake/fsp_params.c
+++ b/src/soc/intel/tigerlake/fsp_params.c
@@ -495,7 +495,7 @@

/* CNVi */
    struct device *port = NULL;
-	struct drivers_usb_acpi_config *usb_cfg;
+	struct drivers_usb_acpi_config *usb_cfg = NULL;
    bool usb_audio_offload = false;

/* Search through the devicetree for matching USB devices */
@@ -528,7 +528,7 @@
    if (params->CnviBtAudioOffload && !usb_audio_offload) {
    	printk(BIOS_WARNING, "CNVi BT Audio offload enabled but not in USB driver.\n");
    }
-	if (!params->CnviBtAudioOffload && usb_audio_offload) {
+	if (!params->CnviBtAudioOffload && usb_cfg && usb_audio_offload) {
    	printk(BIOS_ERR, "USB BT Audio offload enabled but CNVi BT offload disabled\n");
    	usb_cfg->cnvi_bt_audio_offload = 0;
    }