Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80160?usp=email )
Change subject: mb/google/rex/var/karis: Skip tcc_offset override ......................................................................
mb/google/rex/var/karis: Skip tcc_offset override
This change eliminates the unnecessary override of the tcc_offset chip configuration to 10, as the default rex baseboard now handles this setting correctly.
TEST=Successfully built and booted google/karis, confirming tcc_offset remains at 10.
Change-Id: Ie40db1431fb0197ee360ad5656878e57f51c855b Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80160 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tyler Wang tyler.wang@quanta.corp-partner.google.com Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified Tyler Wang: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb index 0233762..371109a 100644 --- a/src/mainboard/google/rex/variants/karis/overridetree.cb +++ b/src/mainboard/google/rex/variants/karis/overridetree.cb @@ -77,8 +77,6 @@ [PchSerialIoIndexI2C5] = PchSerialIoPci, }"
- register "tcc_offset" = "10" - # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |