Attention is currently required from: Tarun Tuli, Tim Wawrzynczak, Arthur Heymans, Shuming Chu (Shuming), TangYiwei.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64343 )
Change subject: cpu/x86: Add function to get logical CPU number based on lapicid
......................................................................
Patch Set 13:
(1 comment)
File src/include/cpu/cpu.h:
https://review.coreboot.org/c/coreboot/+/64343/comment/84964146_bd2aeaba
PS13, Line 12: 0
nit: just specify -1 may be enough here rather saying < 0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67caba8270bc385f64ad5b3f0f287cb77486f2c2
Gerrit-Change-Number: 64343
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Fri, 04 Nov 2022 12:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment