Change in coreboot[master]: util/amdfwtool: add missing zero-initialization for local variable

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47817 )

Change subject: util/amdfwtool: add missing zero-initialization for local variable
......................................................................

util/amdfwtool: add missing zero-initialization for local variable

Change-Id: Ib156b16b874f74f58bd816071db3a7acf33c5aaf
Signed-off-by: Felix Held 
---
M util/amdfwtool/data_parse.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/47817/1

diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c
index c2ce32b..21e7317 100644
--- a/util/amdfwtool/data_parse.c
+++ b/util/amdfwtool/data_parse.c
@@ -224,7 +224,8 @@
 {
    amd_bios_type fw_type = AMD_BIOS_INVALID;
    amd_bios_entry *bhd_tableptr;
-	uint8_t subprog, instance = 0;
+	uint8_t subprog = 0;
+	uint8_t instance = 0;

(void) (cb_config);	/* Remove warning and reserved for future. */

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47817 )

Change subject: util/amdfwtool: add missing zero-initialization for local variable
......................................................................

Patch Set 1: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47817 )

Change subject: util/amdfwtool: add missing zero-initialization for local variable
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47817 )

Change subject: util/amdfwtool: add missing zero-initialization for local variable
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47817 )

Change subject: util/amdfwtool: add missing zero-initialization for local variable
......................................................................

util/amdfwtool: add missing zero-initialization for local variable

Change-Id: Ib156b16b874f74f58bd816071db3a7acf33c5aaf
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47817
Reviewed-by: Furquan Shaikh 
Reviewed-by: Marshall Dawson 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M util/amdfwtool/data_parse.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Marshall Dawson: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c
index c2ce32b..21e7317 100644
--- a/util/amdfwtool/data_parse.c
+++ b/util/amdfwtool/data_parse.c
@@ -224,7 +224,8 @@
 {
    amd_bios_type fw_type = AMD_BIOS_INVALID;
    amd_bios_entry *bhd_tableptr;
-	uint8_t subprog, instance = 0;
+	uint8_t subprog = 0;
+	uint8_t instance = 0;

(void) (cb_config);	/* Remove warning and reserved for future. */