Change in coreboot[master]: util/ifdtool: Use Pch Strap Length(PSL) to uniquely identify IFDv2 ch...
Attention is currently required from: Tim Wawrzynczak, Stefan Reinauer, Angel Pons, Subrata Banik. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54305 )
Change subject: util/ifdtool: Use Pch Strap Length(PSL) to uniquely identify IFDv2 chipsets ......................................................................
Patch Set 3:
(3 comments)
File util/ifdtool/ifdtool.h:
https://review.coreboot.org/c/coreboot/+/54305/comment/91bf02b5_4a822ea4 PS2, Line 38: CHIPSET_N_J_SERIES_APOLLO_GEMINI_LAKE, /* Apollo Lake, Gemini Lake:
APL and GLK have different IFDs (e.g. FLCOMP bitfields are different). I'd handle them separately. […]
Thanks, looks like i missed to read APL and GLK PSL separately, fixed with new patchset
https://review.coreboot.org/c/coreboot/+/54305/comment/f0a09b45_aaedf733 PS2, Line 60: macros
not macros
Ack
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/54305/comment/291caeb1_db9b9626 PS2, Line 273: read_freq = (fcba->flcomp >> 17) & 7;
This bitfield was repurposed in CNP/GLK and newer. […]
on latest platform TGL onward this bitfield is reserved. Don't think we need to act on this ?
-
Subrata Banik (Code Review)