build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46531 )
Change subject: util/sconfig: allow to override chip-wrapped devices
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46531/6/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/46531/6/util/sconfig/main.c@1595
PS6, Line 1595: if (chip_match(base_dev, override_dev))
that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/46531/6/util/sconfig/main.c@1618
PS6, Line 1618: * Update base_chip_instance member in chip instance of override tree to forward it to
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6364b3a6e1804a23503f42c66c5001e42f911270
Gerrit-Change-Number: 46531
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 18 Oct 2020 00:45:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment