Change in ...coreboot[master]: mb/dell: Add Dell Optiplex 790 - coreboot-gerrit

5 Jun 2019


      Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790
......................................................................
Patch Set 54:
(2 comments)
There are some FIXME tags. Are they solvable?
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG@11 
PS54, Line 11: There are (at least) three different mainboards:
say for which of these boards this patch adds support
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG@21 
PS54, Line 21: This port has been tested with: USFF
what is with the Minitower variant?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/21774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f
Gerrit-Change-Number: 21774
Gerrit-PatchSet: 54
Gerrit-Owner: Christoph Pomaska github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Christoph Pomaska github@aufmachen.jetzt
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Johanna Schander coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Wed, 05 Jun 2019 13:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment