Attention is currently required from: Anil Kumar K, Bora Guvendik, Hannah Williams, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84103?usp=email )
Change subject: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table
......................................................................
Patch Set 8:
(2 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84103/comment/8fe42da8_adb0611d?usp... :
PS7, Line 121: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_USE_GPE1)) {
Subrata, […]
okay. At this time, we do want to keep the flag to switch between _USE_GPE1=0 and 1 for PTL at this time. There are things still under development/validation. All individual GPE1 will need to checked and this is still in progress. let me make another change.
https://review.coreboot.org/c/coreboot/+/84103/comment/3fd8a038_8141d93b?usp... :
PS7, Line 128: 8
The unit for gpe1_base is bit and GPE0 block size is in bytes. […]
yes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84103?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6928c35b86f4a2243d58597b17b2a3a5f54271e
Gerrit-Change-Number: 84103
Gerrit-PatchSet: 8
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Fri, 30 Aug 2024 22:30:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com