Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43644 )
Change subject: mb/system76/lemp9: gpio: configure unused pads
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43644/18/src/mainboard/system76/lem...
File src/mainboard/system76/lemp9/gpio.h:
PS18:
Configure the 20k pull-ups for the NC pads in a follow-up commit. Instead configure them with NONE as done with PAD_CFG_NC() and check if the build is reproducible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43644
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia370c180d5ae6f48360be14af3cbab29e6814e75
Gerrit-Change-Number: 43644
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Aug 2020 02:41:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment