Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42204 )
Change subject: templates: remove Dedede and Volteer Makefile.inc ......................................................................
templates: remove Dedede and Volteer Makefile.inc
Because we don't need SPD_SOURCES for Dedede and Volteer-derived variants, there is no reason to have a Makefile.inc now as part of the templates.
BUG=b:158492307 BRANCH=None TEST=Create new variant of volteer, waddledee, and waddledoo, and verify that we can still build the coreboot image.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: Iba5264384302300cc8d2256a6b43f3353770154a --- D util/mainboard/google/volteer/template/Makefile.inc D util/mainboard/google/waddledee/template/Makefile.inc D util/mainboard/google/waddledoo/template/Makefile.inc 3 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/42204/1
diff --git a/util/mainboard/google/volteer/template/Makefile.inc b/util/mainboard/google/volteer/template/Makefile.inc deleted file mode 100644 index 61b23ed..0000000 --- a/util/mainboard/google/volteer/template/Makefile.inc +++ /dev/null @@ -1,4 +0,0 @@ -## -## SPDX-License-Identifier: GPL-2.0-only - -SPD_SOURCES = diff --git a/util/mainboard/google/waddledee/template/Makefile.inc b/util/mainboard/google/waddledee/template/Makefile.inc deleted file mode 100644 index 6861194..0000000 --- a/util/mainboard/google/waddledee/template/Makefile.inc +++ /dev/null @@ -1,3 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-or-later - -SPD_SOURCES += empty #0b0000 diff --git a/util/mainboard/google/waddledoo/template/Makefile.inc b/util/mainboard/google/waddledoo/template/Makefile.inc deleted file mode 100644 index fd8d126..0000000 --- a/util/mainboard/google/waddledoo/template/Makefile.inc +++ /dev/null @@ -1,3 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-or-later - -SPD_SOURCES = empty #0b0000
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42204 )
Change subject: templates: remove Dedede and Volteer Makefile.inc ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42204 )
Change subject: templates: remove Dedede and Volteer Makefile.inc ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42204/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42204/1//COMMIT_MSG@9 PS1, Line 9: we don't need SPD_SOURCES (as SPD_SOURCES are auto-generated by SPD tools)
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42204
to look at the new patch set (#2).
Change subject: templates: remove Dedede and Volteer Makefile.inc ......................................................................
templates: remove Dedede and Volteer Makefile.inc
SPD sources for Dedede and Volteer are being auto-generated by SPD tools now, and so we can remove SPD_SOURCES from Makefile.inc for those templates. That makes Makefile.inc empty for those reference boards, so remove Makefile.inc from the templates.
BUG=b:158492307 BRANCH=None TEST=Create new variant of volteer, waddledee, and waddledoo, and verify that we can still build the coreboot image.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: Iba5264384302300cc8d2256a6b43f3353770154a --- D util/mainboard/google/volteer/template/Makefile.inc D util/mainboard/google/waddledee/template/Makefile.inc D util/mainboard/google/waddledoo/template/Makefile.inc 3 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/42204/2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42204 )
Change subject: templates: remove Dedede and Volteer Makefile.inc ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42204/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42204/1//COMMIT_MSG@9 PS1, Line 9: we don't need SPD_SOURCES
(as SPD_SOURCES are auto-generated by SPD tools)
Done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42204 )
Change subject: templates: remove Dedede and Volteer Makefile.inc ......................................................................
templates: remove Dedede and Volteer Makefile.inc
SPD sources for Dedede and Volteer are being auto-generated by SPD tools now, and so we can remove SPD_SOURCES from Makefile.inc for those templates. That makes Makefile.inc empty for those reference boards, so remove Makefile.inc from the templates.
BUG=b:158492307 BRANCH=None TEST=Create new variant of volteer, waddledee, and waddledoo, and verify that we can still build the coreboot image.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: Iba5264384302300cc8d2256a6b43f3353770154a Reviewed-on: https://review.coreboot.org/c/coreboot/+/42204 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- D util/mainboard/google/volteer/template/Makefile.inc D util/mainboard/google/waddledee/template/Makefile.inc D util/mainboard/google/waddledoo/template/Makefile.inc 3 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/util/mainboard/google/volteer/template/Makefile.inc b/util/mainboard/google/volteer/template/Makefile.inc deleted file mode 100644 index 61b23ed..0000000 --- a/util/mainboard/google/volteer/template/Makefile.inc +++ /dev/null @@ -1,4 +0,0 @@ -## -## SPDX-License-Identifier: GPL-2.0-only - -SPD_SOURCES = diff --git a/util/mainboard/google/waddledee/template/Makefile.inc b/util/mainboard/google/waddledee/template/Makefile.inc deleted file mode 100644 index 6861194..0000000 --- a/util/mainboard/google/waddledee/template/Makefile.inc +++ /dev/null @@ -1,3 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-or-later - -SPD_SOURCES += empty #0b0000 diff --git a/util/mainboard/google/waddledoo/template/Makefile.inc b/util/mainboard/google/waddledoo/template/Makefile.inc deleted file mode 100644 index fd8d126..0000000 --- a/util/mainboard/google/waddledoo/template/Makefile.inc +++ /dev/null @@ -1,3 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-or-later - -SPD_SOURCES = empty #0b0000
-
Furquan Shaikh (Code Review) -
Paul Fagerburg (Code Review)