Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27276 )
Change subject: soc/amd/common: Remove redundant ACPI S3 test ......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/27276/4/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/27276/4/src/soc/amd/common/block/pi/agesawra... PS4, Line 425: : : Essentially the return parameter is only used for debug message, it does not block continuation of code. So if you disable ACPI_S3, and leave the return only on the first and/or maybe the second, S3 would be possible to enter, but when resuming system would hang (all steps must be executed or not). If you block entering S3, then it would be possible to remove these checks, otherwise I would rather you abandon this change.
-
Richard Spiegel (Code Review)