Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21713
Change subject: amd pi: Add agesa_headers.h for all PIs ......................................................................
amd pi: Add agesa_headers.h for all PIs
- Create header files for each PI that pull in all AGESA pi headers. - Add that header to agesawrapper.h and enclose it in #pragma pack push and pop to keep the '#pragma pack(1)' in Porting.h from leaking.
Following patches will update the coreboot code to use only agesawrapper.h to pull in the AGESA headers.
Change-Id: Ib7d76811c1270ec7ef71266d84f3960919b792d4 Signed-off-by: Martin Roth martinroth@google.com --- M src/soc/amd/common/agesawrapper.h A src/vendorcode/amd/pi/00630F01/agesa_headers.h A src/vendorcode/amd/pi/00660F01/agesa_headers.h A src/vendorcode/amd/pi/00670F00/agesa_headers.h A src/vendorcode/amd/pi/00730F01/agesa_headers.h 5 files changed, 205 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/21713/1
diff --git a/src/soc/amd/common/agesawrapper.h b/src/soc/amd/common/agesawrapper.h index b42f531..d9b4c65 100644 --- a/src/soc/amd/common/agesawrapper.h +++ b/src/soc/amd/common/agesawrapper.h @@ -17,8 +17,10 @@ #define __AGESAWRAPPER_H__
#include <stdint.h> +#pragma pack(push) #include <Porting.h> -#include <AGESA.h> +#include <agesa_headers.h> +#pragma pack(pop)
enum { PICK_DMI, /* DMI Interface */ diff --git a/src/vendorcode/amd/pi/00630F01/agesa_headers.h b/src/vendorcode/amd/pi/00630F01/agesa_headers.h new file mode 100644 index 0000000..62a68d9 --- /dev/null +++ b/src/vendorcode/amd/pi/00630F01/agesa_headers.h @@ -0,0 +1,55 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2017 Google, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __AGESA_HEADERS_H__ +#define __AGESA_HEADERS_H__ + +#include "AMD.h" +#include "AGESA.h" +#include "Proc/Fch/Common/FchCommonCfg.h" + +#include "binaryPI/FieldAccessors.h" +#include "Dispatcher.h" +#include "Include/Filecode.h" +#include "Include/Ids.h" +#include "Include/IdsPerf.h" +#include "Include/Options.h" +#include "Include/PlatformMemoryConfiguration.h" +#include "Include/Topology.h" +#include "Proc/Common/AmdFch.h" +#include "Proc/CPU/cpuApicUtilities.h" +#include "Proc/CPU/cpuEarlyInit.h" +#include "Proc/CPU/cpuLateInit.h" +#include "Proc/CPU/cpuRegisters.h" +#include "Proc/CPU/Family/cpuFamRegisters.h" +#include "Proc/CPU/Feature/cpuCacheInit.h" +#include "Proc/CPU/heapManager.h" +#include "Proc/Fch/Common/AcpiLib.h" +#include "Proc/Fch/Common/FchBiosRamUsage.h" +#include "Proc/Fch/Common/FchDef.h" +#include "Proc/Fch/Fch.h" +#include "Proc/Fch/FchPlatform.h" +#include "Proc/IDS/Debug/IdsDebugPrint.h" +#include "Proc/IDS/Debug/IdsDpHdtout.h" +#include "Proc/IDS/Debug/IdsDpRam.h" +#include "Proc/IDS/Family/0x15/IdsF15AllService.h" +#include "Proc/IDS/Family/0x15/KV/IdsF15KvAllService.h" +#include "Proc/IDS/Family/0x15/KV/IdsF15KvNvDef.h" +#include "Proc/IDS/Family/0x15/TN/IdsF15TnAllService.h" +#include "Proc/IDS/Family/0x15/TN/IdsF15TnNvDef.h" +#include "Proc/IDS/IdsLib.h" +#include "Proc/IDS/OptionsIds.h" + +#endif /* __AGESA_HEADERS_H__ */ diff --git a/src/vendorcode/amd/pi/00660F01/agesa_headers.h b/src/vendorcode/amd/pi/00660F01/agesa_headers.h new file mode 100644 index 0000000..e0f6ad9 --- /dev/null +++ b/src/vendorcode/amd/pi/00660F01/agesa_headers.h @@ -0,0 +1,49 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2017 Google, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __AGESA_HEADERS_H__ +#define __AGESA_HEADERS_H__ + +#include "AMD.h" +#include "AGESA.h" +#include "Proc/Fch/Common/FchCommonCfg.h" + +#include "binaryPI/FieldAccessors.h" +#include "binaryPI/OptionsIds.h" +#include "Dispatcher.h" +#include "Include/Filecode.h" +#include "Include/GeneralServices.h" +#include "Include/Ids.h" +#include "Include/IdsPerf.h" +#include "Include/Options.h" +#include "Include/PlatformMemoryConfiguration.h" +#include "Include/Topology.h" +#include "Proc/Common/AmdFch.h" +#include "Proc/CPU/cpuEarlyInit.h" +#include "Proc/CPU/cpuLateInit.h" +#include "Proc/CPU/cpuRegisters.h" +#include "Proc/CPU/Family/cpuFamRegisters.h" +#include "Proc/CPU/Feature/cpuCacheInit.h" +#include "Proc/CPU/heapManager.h" +#include "Proc/Fch/Common/AcpiLib.h" +#include "Proc/Fch/Common/FchBiosRamUsage.h" +#include "Proc/Fch/Common/FchDef.h" +#include "Proc/Fch/Fch.h" +#include "Proc/Fch/FchPlatform.h" +#include "Proc/Fch/Kern/KernFch.h" +#include "Proc/Psp/PspBaseLib/PspBaseLib.h" +#include "Proc/Psp/PspBaseLib/PspDirectory.h" + +#endif /* __AGESA_HEADERS_H__ */ diff --git a/src/vendorcode/amd/pi/00670F00/agesa_headers.h b/src/vendorcode/amd/pi/00670F00/agesa_headers.h new file mode 100644 index 0000000..8c74dca --- /dev/null +++ b/src/vendorcode/amd/pi/00670F00/agesa_headers.h @@ -0,0 +1,52 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2017 Google, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __AGESA_HEADERS_H__ +#define __AGESA_HEADERS_H__ + +#include "AMD.h" +#include "AGESA.h" +#include "Proc/CPU/cpuRegisters.h" +#include "Proc/Fch/Common/FchCommonCfg.h" + +#include "binaryPI/FieldAccessors.h" +#include "binaryPI/OptionsIds.h" +#include "Dispatcher.h" +#include "Include/Filecode.h" +#include "Include/GeneralServices.h" +#include "Include/Ids.h" +#include "Include/IdsPerf.h" +#include "Include/Options.h" +#include "Include/PlatformMemoryConfiguration.h" +#include "Include/Topology.h" +#include "Proc/Common/AmdFch.h" +#include "Proc/CPU/cpuEarlyInit.h" +#include "Proc/CPU/cpuFamilyTranslation.h" +#include "Proc/CPU/cpuLateInit.h" +#include "Proc/CPU/cpuServices.h" +#include "Proc/CPU/Family/cpuFamRegisters.h" +#include "Proc/CPU/Feature/cpuCacheInit.h" +#include "Proc/CPU/heapManager.h" +#include "Proc/CPU/Table.h" +#include "Proc/Fch/Common/AcpiLib.h" +#include "Proc/Fch/Common/FchBiosRamUsage.h" +#include "Proc/Fch/Common/FchDef.h" +#include "Proc/Fch/Fch.h" +#include "Proc/Fch/FchPlatform.h" +#include "Proc/Fch/Kern/KernFch.h" +#include "Proc/Psp/PspBaseLib/PspBaseLib.h" +#include "Proc/Psp/PspBaseLib/PspDirectory.h" + +#endif /* __AGESA_HEADERS_H__ */ diff --git a/src/vendorcode/amd/pi/00730F01/agesa_headers.h b/src/vendorcode/amd/pi/00730F01/agesa_headers.h new file mode 100644 index 0000000..607d7e2 --- /dev/null +++ b/src/vendorcode/amd/pi/00730F01/agesa_headers.h @@ -0,0 +1,46 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2017 Google, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __AGESA_HEADERS_H__ +#define __AGESA_HEADERS_H__ + +#include "AMD.h" +#include "AGESA.h" +#include "Proc/Fch/Common/FchCommonCfg.h" + +#include "Proc/Common/AmdFch.h" +#include "Proc/Fch/Common/AcpiLib.h" +#include "Proc/Fch/Common/FchDef.h" +#include "Proc/Fch/Common/FchBiosRamUsage.h" +#include "Proc/Fch/Fch.h" +#include "Proc/Fch/FchPlatform.h" +#include "Proc/CPU/cpuApicUtilities.h" +#include "Proc/CPU/cpuRegisters.h" +#include "Proc/CPU/heapManager.h" +#include "Proc/CPU/cpuEarlyInit.h" +#include "Proc/CPU/Feature/cpuCacheInit.h" +#include "Proc/CPU/cpuLateInit.h" +#include "Proc/CPU/Family/cpuFamRegisters.h" +#include "binaryPI/FieldAccessors.h" +#include "binaryPI/OptionsIds.h" +#include "Dispatcher.h" +#include "Include/PlatformMemoryConfiguration.h" +#include "Include/Ids.h" +#include "Include/IdsPerf.h" +#include "Include/Options.h" +#include "Include/Topology.h" +#include "Include/Filecode.h" + +#endif /* __AGESA_HEADERS_H__ */
-
Martin Roth (Code Review)