Attention is currently required from: YH Lin, Johnny Li, Zhuohao Lee, Raihow Shi, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62321 )
Change subject: mb/google/brask/variants/moli: init overridetree for moli
......................................................................
Patch Set 24: Code-Review+1
(2 comments)
File src/mainboard/google/brya/variants/moli/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62321/comment/de5fb449_61a2acfc
PS9, Line 58: device ref pcie_rp7 on
: chip drivers/net
: register "wake" = "GPE0_DW0_07"
: register "led_feature" = "0xe0"
: register "customized_led0" = "0x23f"
: register "customized_led2" = "0x028"
: device pci 00.0 on end
: end
: end # RTL8125 Ethernet NIC
i modify it, but i add register "PcieRpSlotImplemented[7]" = "1" this line in setting of RTL8111, it build fail, so i remove it
Yes, we've been pretty much ignoring that UPD for ADL... the default value is 1 for ADL so it hasn't caused us any trouble, but it we should probably program it correctly.
File src/mainboard/google/brya/variants/moli/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62321/comment/0803bad2_cb425dec
PS24, Line 80: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)"
FYI, other projects have ended up also adding the `enable_gpio` for the eMMC controller here for RTD3 support to get to a true D3cold state, so I suspect you will want to do the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8829d4b39d48ae574eeccbfc62e79b671211ae2d
Gerrit-Change-Number: 62321
Gerrit-PatchSet: 24
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 10 Mar 2022 02:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-MessageType: comment